This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix MIPS ELF64 problem with .gpword/.8byte combinations


Richard Sandiford wrote:
[snip]
> + /* Read a macro's relocation codes from *ARGS and store them in *R.
> +    The first argument in *ARGS will be either the code for a single
> +    relocation or -1 followed by the three codes that make up a
> +    composite relocation.  */
> + 
> + static void
> + macro_read_relocs (va_list *args, bfd_reloc_code_real_type *r)
> + {
> +   int i, next;
> + 
> +   next = va_arg (*args, int);
> +   if (next >= 0)
> +     r[0] = (bfd_reloc_code_real_type) next;
> +   else
> +     for (i = 0; i < 3; i++)
> +       r[i] = (bfd_reloc_code_real_type) va_arg (*args, int);
> + }

AFAICS this is likely to cause breakage if we have to support combined
dual relocs.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]