This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Add --warn-shared-textrel option to ld
- From: Nick Clifton <nickc at redhat dot com>
- To: jbaker at qnx dot com
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 30 Sep 2004 18:34:28 +0100
- Subject: Re: [PATCH] Add --warn-shared-textrel option to ld
- References: <4149DBF2.9080207@qnx.com>
Hi Jeff,
This patch was originally included in the QNX Mips support but I'm
posting it on it's own so that the appropriate people might look at it.
Well the patch seems quite reasonable. There are a couple of minor
problems with it however:
* The formatting of the code added to elflink.c does not follow the
GNU Coding Standards; (the opening curly brace should be on its own line).
* The patch adds a new command line switch to the linker, but it does
not add documentation on this switch to the ld.texinfo file, nor does it
add a line to the ld/NEWS file.
Cheers
Nick