This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add --warn-shared-textrel option to ld


Hi Jeff,

This patch was originally included in the QNX Mips support but I'm posting it on it's own so that the appropriate people might look at it.

Well the patch seems quite reasonable. There are a couple of minor problems with it however:


* The formatting of the code added to elflink.c does not follow the GNU Coding Standards; (the opening curly brace should be on its own line).

* The patch adds a new command line switch to the linker, but it does not add documentation on this switch to the ld.texinfo file, nor does it add a line to the ld/NEWS file.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]