This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: ppc64 synthetic symtab
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Sat, 28 Aug 2004 12:26:44 +0930
- Subject: Re: ppc64 synthetic symtab
- References: <20040827145613.GG11740@bubble.modra.org>
We need this one too. Static binaries don't have a dynamic symbol
table, so for them objdump wasn't calling bfd_get_synthetic_symtab.
In any case, the normal symbol table usually has more symbols
available, so we can recreate more of the function entry points this
way.
bfd/
* bfd.c (bfd_get_synthetic_symtab): Pass counts and both symbol tables.
* elf-bfd.h (_bfd_elf_get_synthetic_symtab): Adjust.
* elf.c (_bfd_elf_get_synthetic_symtab): Adjust.
* libbfd-in.h (_bfd_nodynamic_get_synthetic_symtab): Adjust.
* targets.c (struct bfd_target <_bfd_get_synthetic_symtab>): Adjust.
* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't read symbols.
Use both symbol tables on non-relocatable objects. Use a common
error exit. Fix "mid" warning.
* libbfd.h: Regenerate.
* bfd-in2.h: Regenerate.
binutils/
* objdump.c (dump_bfd): Pass both symbol tables to
bfd_get_synthetic_symtab.
Index: bfd/bfd.c
===================================================================
RCS file: /cvs/src/src/bfd/bfd.c,v
retrieving revision 1.67
diff -u -p -r1.67 bfd.c
--- bfd/bfd.c 17 Aug 2004 09:07:35 -0000 1.67
+++ bfd/bfd.c 28 Aug 2004 02:38:16 -0000
@@ -1218,8 +1218,9 @@ DESCRIPTION
.#define bfd_canonicalize_dynamic_symtab(abfd, asymbols) \
. BFD_SEND (abfd, _bfd_canonicalize_dynamic_symtab, (abfd, asymbols))
.
-.#define bfd_get_synthetic_symtab(abfd, relsyms, ret) \
-. BFD_SEND (abfd, _bfd_get_synthetic_symtab, (abfd, relsyms, ret))
+.#define bfd_get_synthetic_symtab(abfd, count, syms, dyncount, dynsyms, ret) \
+. BFD_SEND (abfd, _bfd_get_synthetic_symtab, (abfd, count, syms, \
+. dyncount, dynsyms, ret))
.
.#define bfd_get_dynamic_reloc_upper_bound(abfd) \
. BFD_SEND (abfd, _bfd_get_dynamic_reloc_upper_bound, (abfd))
Index: bfd/elf-bfd.h
===================================================================
RCS file: /cvs/src/src/bfd/elf-bfd.h,v
retrieving revision 1.153
diff -u -p -r1.153 elf-bfd.h
--- bfd/elf-bfd.h 9 Aug 2004 06:02:02 -0000 1.153
+++ bfd/elf-bfd.h 28 Aug 2004 02:38:20 -0000
@@ -1438,7 +1438,7 @@ extern long _bfd_elf_get_dynamic_symtab_
extern long _bfd_elf_canonicalize_dynamic_symtab
(bfd *, asymbol **);
extern long _bfd_elf_get_synthetic_symtab
- (bfd *, asymbol **, asymbol **);
+ (bfd *, long, asymbol **, long, asymbol **, asymbol **);
extern long _bfd_elf_get_reloc_upper_bound
(bfd *, sec_ptr);
extern long _bfd_elf_canonicalize_reloc
Index: bfd/elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.239
diff -u -p -r1.239 elf.c
--- bfd/elf.c 17 Aug 2004 09:07:35 -0000 1.239
+++ bfd/elf.c 28 Aug 2004 02:38:24 -0000
@@ -7744,7 +7744,12 @@ bfd_elf_bfd_from_remote_memory
}
long
-_bfd_elf_get_synthetic_symtab (bfd *abfd, asymbol **relsyms, asymbol **ret)
+_bfd_elf_get_synthetic_symtab (bfd *abfd,
+ long symcount ATTRIBUTE_UNUSED,
+ asymbol **syms ATTRIBUTE_UNUSED,
+ long dynsymcount ATTRIBUTE_UNUSED,
+ asymbol **dynsyms,
+ asymbol **ret)
{
const struct elf_backend_data *bed = get_elf_backend_data (abfd);
asection *relplt;
@@ -7782,7 +7787,7 @@ _bfd_elf_get_synthetic_symtab (bfd *abfd
return 0;
slurp_relocs = get_elf_backend_data (abfd)->s->slurp_reloc_table;
- if (! (*slurp_relocs) (abfd, relplt, relsyms, TRUE))
+ if (! (*slurp_relocs) (abfd, relplt, dynsyms, TRUE))
return -1;
count = relplt->size / hdr->sh_entsize;
Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.168
diff -u -p -r1.168 elf64-ppc.c
--- bfd/elf64-ppc.c 27 Aug 2004 14:54:41 -0000 1.168
+++ bfd/elf64-ppc.c 28 Aug 2004 02:38:29 -0000
@@ -2645,16 +2645,18 @@ sym_exists_at (asymbol **syms, long lo,
entry syms. */
static long
-ppc64_elf_get_synthetic_symtab (bfd *abfd, asymbol **relsyms, asymbol **ret)
+ppc64_elf_get_synthetic_symtab (bfd *abfd, long symcount, asymbol **syms,
+ long dynsymcount, asymbol **dynsyms,
+ asymbol **ret)
{
asymbol *s;
long i;
long count;
char *names;
- asymbol **syms = NULL;
- long symcount = 0, codesecsym, codesecsymend, secsymend, opdsymend;
+ long codesecsym, codesecsymend, secsymend, opdsymend;
asection *opd;
bfd_boolean relocatable = (abfd->flags & (EXEC_P | DYNAMIC)) == 0;
+ asymbol **sy = NULL;
*ret = NULL;
@@ -2662,61 +2664,46 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
if (opd == NULL)
return 0;
- if ((bfd_get_file_flags (abfd) & HAS_SYMS))
+ if (!relocatable)
{
- long storage;
- storage = bfd_get_symtab_upper_bound (abfd);
- if (storage < 0)
- return 0;
-
- if (storage)
+ if (symcount != 0 && dynsymcount != 0)
{
- syms = bfd_malloc (storage);
- if (syms == NULL)
+ /* Use both symbol tables. */
+ sy = bfd_malloc ((symcount + dynsymcount + 1) * sizeof (*syms));
+ if (sy == NULL)
return 0;
+ memcpy (sy, syms, symcount * sizeof (*syms));
+ memcpy (sy + symcount, dynsyms, (dynsymcount + 1) * sizeof (*syms));
+ syms = sy;
+ symcount = symcount + dynsymcount;
}
-
- symcount = bfd_canonicalize_symtab (abfd, syms);
- if (symcount < 0)
- {
- free (syms);
- return 0;
- }
-
- if (symcount == 0)
+ else if (symcount == 0)
{
- free (syms);
- syms = NULL;
+ syms = dynsyms;
+ symcount = dynsymcount;
}
}
if (symcount == 0)
- {
- long storage;
-
- storage = bfd_get_dynamic_symtab_upper_bound (abfd);
- if (storage < 0)
- return 0;
-
- if (storage)
- {
- syms = bfd_malloc (storage);
- if (syms == NULL)
- return 0;
- }
-
- symcount = bfd_canonicalize_dynamic_symtab (abfd, syms);
- if (symcount < 0)
- {
- free (syms);
- return 0;
- }
- }
+ return 0;
synthetic_opd = opd;
synthetic_relocatable = relocatable;
qsort (syms, symcount, sizeof (asymbol *), compare_symbols);
+ if (!relocatable && symcount > 1)
+ {
+ long j;
+ /* Trim duplicate syms, since we may have merged the normal and
+ dynamic symbols. Actually, we only care about syms that have
+ different values, so trim any with the same value. */
+ for (i = 1, j = 1; i < symcount; ++i)
+ if (syms[i - 1]->value + syms[i - 1]->section->vma
+ != syms[i]->value + syms[i]->section->vma)
+ syms[j++] = syms[i];
+ symcount = j;
+ }
+
i = 0;
if (syms[i]->section == opd)
++i;
@@ -2745,13 +2732,10 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
break;
symcount = i;
+ count = 0;
if (opdsymend == secsymend)
- {
- free (syms);
- return 0;
- }
+ goto done;
- count = 0;
if (relocatable)
{
bfd_boolean (*slurp_relocs) (bfd *, asection *, asymbol **, bfd_boolean);
@@ -2765,11 +2749,8 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
relcount = (opd->flags & SEC_RELOC) ? opd->reloc_count : 0;
if (! relcount
- || ! (*slurp_relocs) (abfd, relopd, relsyms, FALSE))
- {
- free (syms);
- return 0;
- }
+ || ! (*slurp_relocs) (abfd, relopd, syms, FALSE))
+ goto done;
size = 0;
for (i = secsymend, r = relopd->relocation; i < opdsymend; ++i)
@@ -2802,8 +2783,8 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
s = *ret = bfd_malloc (size);
if (s == NULL)
{
- free (syms);
- return 0;
+ count = 0;
+ goto done;
}
names = (char *) (s + count);
@@ -2851,9 +2832,11 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
if (!bfd_malloc_and_get_section (abfd, opd, &contents))
{
if (contents)
- free (contents);
- free (syms);
- return 0;
+ {
+ free_contents_and_exit:
+ free (contents);
+ }
+ goto done;
}
size = 0;
@@ -2873,9 +2856,8 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
s = *ret = bfd_malloc (size);
if (s == NULL)
{
- free (contents);
- free (syms);
- return 0;
+ count = 0;
+ goto free_contents_and_exit;
}
names = (char *) (s + count);
@@ -2887,30 +2869,29 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
ent = bfd_get_64 (abfd, contents + syms[i]->value);
if (!sym_exists_at (syms, opdsymend, symcount, -1, ent))
{
- long lo, hi, mid;
+ long lo, hi;
size_t len;
- asection *sec;
+ asection *sec = abfd->sections;
*s = *syms[i];
lo = codesecsym;
hi = codesecsymend;
while (lo < hi)
{
- mid = (lo + hi) >> 1;
+ long mid = (lo + hi) >> 1;
if (syms[mid]->section->vma < ent)
lo = mid + 1;
else if (syms[mid]->section->vma > ent)
hi = mid;
else
- break;
+ {
+ sec = syms[mid]->section;
+ break;
+ }
}
- if (lo < hi)
- sec = syms[mid]->section;
- else if (lo > codesecsym)
+ if (lo >= hi && lo > codesecsym)
sec = syms[lo - 1]->section;
- else
- sec = abfd->sections;
for (; sec != NULL; sec = sec->next)
{
@@ -2934,7 +2915,9 @@ ppc64_elf_get_synthetic_symtab (bfd *abf
free (contents);
}
- free (syms);
+ done:
+ if (sy != NULL)
+ free (sy);
return count;
}
Index: bfd/libbfd-in.h
===================================================================
RCS file: /cvs/src/src/bfd/libbfd-in.h,v
retrieving revision 1.41
diff -u -p -r1.41 libbfd-in.h
--- bfd/libbfd-in.h 30 Jul 2004 15:37:04 -0000 1.41
+++ bfd/libbfd-in.h 28 Aug 2004 02:38:29 -0000
@@ -387,7 +387,7 @@ extern bfd_boolean _bfd_generic_set_sect
#define _bfd_nodynamic_canonicalize_dynamic_symtab \
((long (*) (bfd *, asymbol **)) _bfd_n1)
#define _bfd_nodynamic_get_synthetic_symtab \
- ((long (*) (bfd *, asymbol **, asymbol **)) _bfd_n1)
+ ((long (*) (bfd *, long, asymbol **, long, asymbol **, asymbol **)) _bfd_n1)
#define _bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_n1
#define _bfd_nodynamic_canonicalize_dynamic_reloc \
((long (*) (bfd *, arelent **, asymbol **)) _bfd_n1)
Index: bfd/targets.c
===================================================================
RCS file: /cvs/src/src/bfd/targets.c,v
retrieving revision 1.115
diff -u -p -r1.115 targets.c
--- bfd/targets.c 27 Jul 2004 22:30:24 -0000 1.115
+++ bfd/targets.c 28 Aug 2004 02:38:31 -0000
@@ -475,8 +475,9 @@ BFD_JUMP_TABLE macros.
. (bfd *, struct bfd_symbol **);
. {* Create synthetized symbols. *}
. long (*_bfd_get_synthetic_symtab)
-. (bfd *, struct bfd_symbol **, struct bfd_symbol **);
+. (bfd *, long, struct bfd_symbol **, long, struct bfd_symbol **,
+. struct bfd_symbol **);
. {* Get the amount of memory required to hold the dynamic relocs. *}
. long (*_bfd_get_dynamic_reloc_upper_bound) (bfd *);
. {* Read in the dynamic relocs. *}
Index: binutils/objdump.c
===================================================================
RCS file: /cvs/src/src/binutils/objdump.c,v
retrieving revision 1.93
diff -u -p -r1.93 objdump.c
--- binutils/objdump.c 17 Aug 2004 09:07:35 -0000 1.93
+++ binutils/objdump.c 28 Aug 2004 02:39:06 -0000
@@ -2566,18 +2566,10 @@ dump_bfd (bfd *abfd)
dynsyms = slurp_dynamic_symtab (abfd);
if (disassemble)
{
- synthcount = 0;
- if (bfd_get_file_flags (abfd) & (DYNAMIC | EXEC_P))
- {
- if (dynsymcount > 0)
- synthcount = bfd_get_synthetic_symtab (abfd, dynsyms, &synthsyms);
- }
- else
- {
- if (symcount > 0)
- synthcount = bfd_get_synthetic_symtab (abfd, syms, &synthsyms);
- }
- if (synthcount < 0) synthcount = 0;
+ synthcount = bfd_get_synthetic_symtab (abfd, symcount, syms,
+ dynsymcount, dynsyms, &synthsyms);
+ if (synthcount < 0)
+ synthcount = 0;
}
if (dump_symtab)
--
Alan Modra
IBM OzLabs - Linux Technology Centre