Re: Patch to improve MIPS %hi/%lo matching

[Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>]

Richard Sandiford wrote:
[snip]
> >> ! 	 We don't warn about unmatched high-part relocations since some
> >> ! 	 versions of gcc have been known to emit dead "lui ...%hi(...)"
> >> ! 	 instructions.  */
> >
> > Which versions of gcc exactly? Or is the "have been known" part
> > actually true? :-)
> 
> Good question ;)  That was really just a rewording of:
> 
> #if 0 /* GCC code motion plus incomplete dead code elimination
> 	 can leave a %hi without a %lo.  */
> 	  if (pass == 1)
> 	    as_warn_where (l->fixp->fx_file, l->fixp->fx_line,
> 			   _("Unmatched %%hi reloc"));
> #endif
> 
> but I've no idea which version it applies to.  I certainly _hope_
> modern gccs aren't affected...

Can you add some indication of the gcc version to the comment?
"gcc versions earlier than ??? may emit...". This gives us a chance to
catch potential bugs after those gcc versions become obsolete.


Thiemo