This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[patch] MIPS: Fix an orphaned LO16 reloc in elf-rel9
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: binutils at sources dot redhat dot com
- Date: Mon, 28 Jun 2004 19:25:26 +0200 (CEST)
- Subject: [patch] MIPS: Fix an orphaned LO16 reloc in elf-rel9
Hello,
This is a follow-on patch to the "mips-hilo-reloc-sort" one. There is an
orphaned LO16 reloc in the "elf-rel9" test case. It is clearly a typo.
An obvious fix follows.
2004-06-28 Maciej W. Rozycki <macro@linux-mips.org>
* gas/mips/elf-rel9.s: Fix a typo.
* gas/mips/elf-rel9.d: Adjust accordingly.
This has been tested for the mipsel-linux-gnu target with no new
regressions and fixing a failure revealed by the "mips-hilo-reloc-sort"
patch in this test case.
OK to apply?
Maciej
binutils-2.15.91-20040625-mips-elf-rel9.patch
diff -up --recursive --new-file binutils-2.15.91-20040625.macro/gas/testsuite/gas/mips/elf-rel9.d binutils-2.15.91-20040625/gas/testsuite/gas/mips/elf-rel9.d
--- binutils-2.15.91-20040625.macro/gas/testsuite/gas/mips/elf-rel9.d 2003-02-02 19:37:20.000000000 +0000
+++ binutils-2.15.91-20040625/gas/testsuite/gas/mips/elf-rel9.d 2004-06-27 19:24:39.000000000 +0000
@@ -45,7 +45,7 @@ Disassembly of section \.text:
44: R_MIPS_LO16 \.data
48: 8f840002 lw \$4,2\(\$28\)
48: R_MIPS_GOT16 \.data
- 4c: 2484f100 addiu \$4,\$4,-3840
+ 4c: 24840000 addiu \$4,\$4,0
4c: R_MIPS_LO16 \.data
50: 8f840003 lw \$4,3\(\$28\)
50: R_MIPS_GOT16 \.data
diff -up --recursive --new-file binutils-2.15.91-20040625.macro/gas/testsuite/gas/mips/elf-rel9.s binutils-2.15.91-20040625/gas/testsuite/gas/mips/elf-rel9.s
--- binutils-2.15.91-20040625.macro/gas/testsuite/gas/mips/elf-rel9.s 2003-02-02 19:37:20.000000000 +0000
+++ binutils-2.15.91-20040625/gas/testsuite/gas/mips/elf-rel9.s 2004-06-27 19:25:04.000000000 +0000
@@ -28,7 +28,7 @@ foo:
addiu $4,$4,%lo(l2 + 0xfff)
lw $4,%got(l2 + 0x1000)($28)
- addiu $4,$4,%lo(l2 + 0x100)
+ addiu $4,$4,%lo(l2 + 0x1000)
lw $4,%got(l2 + 0x12345)($28)
addiu $4,$4,%lo(l2 + 0x12345)