Re: PATCH: Support mixing COMDAT and linkonce

["H. J. Lu" <hjl at lucon dot org>]

On Mon, May 17, 2004 at 02:24:23PM -0700, H. J. Lu wrote:
> On Sat, May 15, 2004 at 11:09:47AM +0930, Alan Modra wrote:
> > On Fri, May 14, 2004 at 02:07:37PM -0700, H. J. Lu wrote:
> > > When there are mixed COMDAT and linkonce inputs, linker doesn't handle
> > > them gracefully:
> > 
> > Ewww.  Should we even try?  I understand that such a patch might be
> > useful while gcc is emitting both comdat and linkonce, but once you've
> > completed the change to comdat it shouldn't be necessary.  Also, I'm not
> > really happy with where you have added this code.  At least, it is the
> > wrong place to be discarding duplicate sections.  That ought to happen
> > in ldlang.c:section_already_linked.
> > 
> 
> This patch implements it.
> 
> 

Here is an update. I should skip checking members of section groups
for already linked section.

I think there may be a bug in ldlang.c:section_already_linked. We
check section names for linkonce sections. But for group sections,
section names are meaningless. Compilers/assemblers don't have to
use group signature for section name.  Shouldn't we check for group
signatures instead?


H.J.

Attachment: bfd-comdat-linkonce-3.patch
Description: Text document