This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [rfa] Add bfd-in-memory io vector
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 2 May 2004 23:26:41 +0930
- Subject: Re: [rfa] Add bfd-in-memory io vector
- References: <4092CA10.6090205@gnu.org> <4093E817.9060704@gnu.org>
On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
> The testing comment still applies though.
Given DJ's comment, I think you should test this on cygwin before
committing. If you can't do this yourself, convince someone else
to do so for you. OK to commit once you've done this.
> --- opncls.c 23 Apr 2004 00:22:57 -0000 1.23
> +++ opncls.c 1 May 2004 18:01:00 -0000
[snip]
> + if ((abfd->direction == write_direction) ||
> + (abfd->direction == both_direction))
I know this was copied from the old code, but please fix the
formatting here and remove the unnecessary parentheses.
> + bim = ((struct bfd_in_memory *)
> + bfd_alloc (abfd, (bfd_size_type) sizeof (struct bfd_in_memory)));
Two unnecessary casts.
--
Alan Modra
IBM OzLabs - Linux Technology Centre