This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] Add bfd-in-memory io vector


On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
> The testing comment still applies though.

Given DJ's comment, I think you should test this on cygwin before
committing.  If you can't do this yourself, convince someone else
to do so for you.  OK to commit once you've done this.

> --- opncls.c	23 Apr 2004 00:22:57 -0000	1.23
> +++ opncls.c	1 May 2004 18:01:00 -0000
[snip]
> +      if ((abfd->direction == write_direction) ||
> +	  (abfd->direction == both_direction))

I know this was copied from the old code, but please fix the
formatting here and remove the unnecessary parentheses.

> +   bim = ((struct bfd_in_memory *)
> +	  bfd_alloc (abfd, (bfd_size_type) sizeof (struct bfd_in_memory)));

Two unnecessary casts.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]