This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [mips patch rfc/rfa] get rid of coff embedded-pic support.
cgd@broadcom.com wrote:
> At Fri, 23 Apr 2004 23:42:34 +0000 (UTC), "Thiemo Seufer" wrote:
> > cgd@broadcom.com wrote:
> > [snip]
> > > [ bfd/ChangeLog ]
> > > 2004-04-22 Chris Demetriou <cgd@broadcom.com>
> > >
> > > * coff-mips.c (mips_relhi_reloc, mips_rello_reloc)
> > > (mips_switch_reloc, mips_read_relocs, mips_relax_section)
> > > (mips_relax_pcrel16, PCREL16_EXPANSION_ADJUSTMENT): Remove.
> > > (mips_relocate_hi): Remove now-unused 'adjust' and 'pcrel' arguments,
> > > and update comments to reflect current usage.
> > > (mips_howto_table): Remove entries for MIPS_R_RELHI, MIPS_R_RELLO,
> > > and MIPS_R_SWITCH, as well as several empty entries. Update comment
> > > for MIPS_R_PCREL16.
> >
> > Does this make %hi, %lo ELF-only? If yes, then gas should be updated
> > accordingly.
>
> Uh, don't think so -- %hi and %lo (do or should) use BFD_RELOC_HI16_S
> (-> MIPS_R_REFHI) and BFD_RELOC_LO16 (-> MIPS_R_REFLO).
>
> (Note REF vs. REL; the latter were used for PC-relative lo/hi only,
> which is only used for embedded-pic.)
Ah, I missed that. I'm not too familiar with ECOFF. :-)
> Looking at the assembler src, they do seem to use BFD_RELOC_HI16_S /
> BFD_RELOC_LO16 as expected.
>
> (The assembler should be updated to GC all of the embedded-pic stuff,
> yes. But i'm trying to take this in stages.
Sure.
> Especially since some of
> the bits in the assembler are fairly ... twisty. Once it's all done,
> the COFF MIPS_R_PCREL16 reloc and the corresponding ELF one should
> probably go away as well.)
I'd like to retain the ELF MIPS_R_PCREL16, and implement external
branches with it again.
Thiemo