This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: VIA PadLock support
Alan Modra told me that:
On Fri, Mar 12, 2004 at 11:40:00AM +0100, Michal Ludvig wrote:
Thanks! Fixed the style and comitted.
I'm getting rusty on x86. OK'd it too quickly, failing to see that
your padlock i386-dis.c code fits in the GRP handling code quite
easily.. I've fixed that.
I was experimenting with GRP for this as well, but didn't figure out how
to use it. Incidentally I comitted some bits from my experiments.
Reverted now (obvious patch attached).
I have two more bits for approval: add 'xstore' insn as an alias for
'xstorerng' and a testsuite for these new instructions.
Both are attached. OK to apply?
Yes.
Done, thanks.
Michal Ludvig
--
SUSE Labs mludvig@suse.cz | Cray is the only computer
(+420) 296.545.373 http://www.suse.cz | that runs an endless loop
Personal homepage http://www.logix.cz/michal | in just four hours.
Index: opcodes/ChangeLog
===================================================================
RCS file: /cvs/src/src/opcodes/ChangeLog,v
retrieving revision 1.667
diff -u -p -r1.667 ChangeLog
--- opcodes/ChangeLog 12 Mar 2004 13:06:48 -0000 1.667
+++ opcodes/ChangeLog 12 Mar 2004 13:34:46 -0000
@@ -1,3 +1,8 @@
+2004-03-12 Michal Ludvig <mludvig@suse.cz>
+
+ * i386-dis.c (GRPPLOCK): Delete.
+ (grps): Detele GRPPLOCK entry.
+
2004-03-12 Alan Modra <amodra@bigpond.net.au>
* i386-dis.c (OP_M, OP_0f0e, OP_0fae, NOP_Fixup): New functions.
Index: opcodes/i386-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/i386-dis.c,v
retrieving revision 1.46
diff -u -p -r1.46 i386-dis.c
--- opcodes/i386-dis.c 12 Mar 2004 13:06:48 -0000 1.46
+++ opcodes/i386-dis.c 12 Mar 2004 13:34:47 -0000
@@ -393,8 +393,7 @@ fetch_data (struct disassemble_info *inf
#define GRP13 NULL, NULL, USE_GROUPS, NULL, 20, NULL, 0
#define GRP14 NULL, NULL, USE_GROUPS, NULL, 21, NULL, 0
#define GRPAMD NULL, NULL, USE_GROUPS, NULL, 22, NULL, 0
-#define GRPPLOCK NULL, NULL, USE_GROUPS, NULL, 23, NULL, 0
-#define GRPPADLCK NULL, NULL, USE_GROUPS, NULL, 24, NULL, 0
+#define GRPPADLCK NULL, NULL, USE_GROUPS, NULL, 23, NULL, 0
#define PREGRP0 NULL, NULL, USE_PREFIX_USER_TABLE, NULL, 0, NULL, 0
#define PREGRP1 NULL, NULL, USE_PREFIX_USER_TABLE, NULL, 1, NULL, 0
@@ -1453,17 +1452,6 @@ static const struct dis386 grps[][8] = {
{ "(bad)", XX, XX, XX },
{ "(bad)", XX, XX, XX },
{ "(bad)", XX, XX, XX },
- { "(bad)", XX, XX, XX },
- { "(bad)", XX, XX, XX },
- },
- /* GRPPLOCK */
- {
- { "xstore", XX, XX, XX },
- { "xcryptecb", XX, XX, XX },
- { "xcryptcbc", XX, XX, XX },
- { "(bad)", XX, XX, XX },
- { "xcryptcfb", XX, XX, XX },
- { "xcryptofb", XX, XX, XX },
{ "(bad)", XX, XX, XX },
{ "(bad)", XX, XX, XX },
},