This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: warnings in libiberty/testsuite/test-demangle.c
- From: Ian Lance Taylor <ian at wasabisystems dot com>
- To: Andreas Jaeger <aj at suse dot de>
- Cc: binutils at sources dot redhat dot com
- Date: 07 Mar 2004 08:53:36 -0500
- Subject: Re: warnings in libiberty/testsuite/test-demangle.c
- References: <m3oer9rmuw.fsf@gromit.moeb>
Andreas Jaeger <aj@suse.de> writes:
> I just noticed the following warnings:
> ../../../libiberty/testsuite/test-demangle.c: In function `main':
> ../../../libiberty/testsuite/test-demangle.c:181: warning: implicit declaration
> unction `strcspn'
> ../../../libiberty/testsuite/test-demangle.c:184: warning: implicit declaration
> unction `strcmp'
> ../../../libiberty/testsuite/test-demangle.c:217: warning: implicit declaration
> unction `strspn'
> ../../../libiberty/testsuite/test-demangle.c:261: warning: implicit declaration
> unction `free'
>
> Ok to commit the appended patch?
Sure, but the master repository for libiberty is gcc, so check it into
the gcc repository, not the src repository.
> Btw. there's also this warning which seems to be true:
>
> /cvs/binutils-ln/libiberty/testsuite/test-demangle.c: In function `main':
> /cvs/binutils-ln/libiberty/testsuite/test-demangle.c:128: warning: `style' might be used uninitialized in this function
Yes, I suppose we should check that it is set around the option
processing loop. A patch for that is OK to check in too.
Thanks.
Ian