This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Simplify mips16 conversion to even address
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: fnf at redhat dot com
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 06 Mar 2004 11:36:51 +0000
- Subject: Re: [PATCH] Simplify mips16 conversion to even address
- References: <200403042153.58621.fnf@ninemoons.com>
Fred Fish <fnf@ninemoons.com> writes:
> @@ -6814,9 +6814,8 @@ _bfd_mips_elf_finish_dynamic_symbol (bfd
> }
>
> /* If this is a mips16 symbol, force the value to be even. */
> - if (sym->st_other == STO_MIPS16
> - && (sym->st_value & 1) != 0)
> - --sym->st_value;
> + if (sym->st_other == STO_MIPS16)
> + sym->st_value &= ~1;
This isn't 64-bit clean, is it? Not that anyone uses elf64 for
mips16 AFAIK, but still...
Richard