This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: readelf.c change

From: Nick Clifton <nickc at redhat dot com>
To: Daniel Lucq <daniel at lucq dot org>
Cc: binutils at sources dot redhat dot com
Date: Mon, 23 Feb 2004 08:46:44 +0000
Subject: Re: readelf.c change
References: <Pine.BSO.4.58.0402221926220.12002@snorlax.internal.custodix.com>

Hi Daniel,

> given that conflictsno is an unsigned type (size_t), wouldn't it be more 
> logical to make the change listed below to readelf.c?
Yup,
  
> -      printf (_("\nSection '.conflict' contains %ld entries:\n"),
> -	      (long) conflictsno);
> +      printf (_("\nSection '.conflict' contains %lu entries:\n"),
> +	      (unsigned long) conflictsno);
>        puts (_("  Num:    Index       Value  Name"));
>  
>        for (cnt = 0; cnt < conflictsno; ++cnt)

I have applied this patch along with this ChangeLog entry:

  2004-02-23  Daniel Lucq  <daniel@lucq.org>

	* readelf.c (process_mips_specific): Print conflictsno as an
	unsigned long.


Cheers
        Nick

References:
- readelf.c change
  - From: Daniel Lucq

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]