This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Another MIPS multigot patch


On Mon, Feb 16, 2004 at 08:07:33AM +0000, Richard Sandiford wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> > On Sun, Feb 15, 2004 at 10:01:25PM +0000, Richard Sandiford wrote:
> >> I think the problem is simply that check_relocs() was only checking
> >> whether the symbol was defined, not whether the symbol was defined
> >> by a regular or shared object.
> >> 
> > I will do this and let you know if the build works.
> 
> Thanks.
> 
> > Do you expect the proposed assertion to succeed now?
> 
> Yeah, I just wasn't sure whether it was worth keeping in the final version.
> If you think it is, I suggest we move it outside the switch statement.
> It isn't really specific to GOT_PAGE relocations.

I would prefer that.

I've just finished a build.  Everything came out OK, and the assertion
never triggered.  Will you commit the patch?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]