This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Another MIPS multigot patch


On Sun, Feb 15, 2004 at 10:01:25PM +0000, Richard Sandiford wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> > I have put it at:
> >   http://www.false.org/~drow/binutils-mips-got.tgz
> 
> Thanks.  In hindsight, I really should have been able to work it
> out from your description, sorry about that.
> 
> I think the problem is simply that check_relocs() was only checking
> whether the symbol was defined, not whether the symbol was defined
> by a regular or shared object.
> 
> The patch below seems to do the trick.  I'll run a bootstrap on irix,
> but since you seem to trip over the problem more often, it'd be great
> if you could give it a spin.

I will do this and let you know if the build works.  Do you expect the
proposed assertion to succeed now?

> I've attached a shell archive (to be run from the top level of the
> build directory).  Before the patch, a.x needlessly had a global GOT
> entry for gs.  After the patch, both a.x and b.x only have a global
> GOT entry for "us".

Interested in adding this to the testsuite? :)


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]