This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: arm-wince-pe support resurrection
- From: Nick Clifton <nickc at redhat dot com>
- To: <Dmitry dot Semyonov at oktet dot ru>
- Cc: <binutils at sources dot redhat dot com>
- Date: Fri, 02 Jan 2004 13:32:29 +0000
- Subject: Re: arm-wince-pe support resurrection
- References: <Pine.LNX.4.33.0312172137480.7653-100000@mail.oktet.ru>
Hi Dmitry,
>> > What was the purpose of this part of the patch ?
>
> Nothing shall be relocated inside raw sections data during partial
> linking if howto->partial_inplace is set to FALSE.
>
> What would you say about the following patch instead of the above
> one?
Much better - I defintely prefer patches to target specific files as
opposed to generic files.
> Note that I can only verify the partial linking since the final link
> stage is performed with MS tools.
>
>
> *** coff-arm.c.1.49 Wed Dec 17 21:29:45 2003
> --- coff-arm.c Fri Dec 19 23:07:11 2003
> *************** coff_arm_relocate_section (output_bfd, i
> *** 1734,1743 ****
> #endif
> else
> #endif /* THUMBEXTENSION */
> ! rstat = _bfd_final_link_relocate (howto, input_bfd, input_section,
> ! contents,
> ! rel->r_vaddr - input_section->vma,
> ! val, addend);
> #if 1 /* THUMBEXTENSION */
> /* FIXME:
> Is this the best way to fix up thumb addresses? krk@cygnus.com
> --- 1734,1746 ----
> #endif
> else
> #endif /* THUMBEXTENSION */
> ! if (info->relocatable && ! howto->partial_inplace)
> ! rstat = bfd_reloc_ok;
> ! else
> ! rstat = _bfd_final_link_relocate (howto, input_bfd, input_section,
> ! contents,
> ! rel->r_vaddr - input_section->vma,
> ! val, addend);
> #if 1 /* THUMBEXTENSION */
> /* FIXME:
> Is this the best way to fix up thumb addresses? krk@cygnus.com
A simpler version of this patch would be to set the 'done' variable if
performing a relocatable link and the reloc has partial_inplace set as
false...
Cheers
Nick