This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
warning fixes
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Thu, 4 Dec 2003 22:37:19 +1030
- Subject: warning fixes
bfd/ChangeLog
* coff-i860.c (coff_i860_reloc_nyi): Return bfd_reloc_not_supported.
* elf-m10300.c (elf32_mn10300_finish_hash_table_entry): Warning fixes.
(mn10300_elf_relax_section): Likewise.
* nlm32-alpha.c (ONES): Define.
(nlm32_alpha_howto_table): Use it to avoid warnings.
ld/ChangeLog
* ldlang.c (lang_do_assignments): Function return is void.
* ldlang.h (lang_do_assignments): Ditto.
* emultempl/netbsd.em (gld${EMULATION_NAME}_before_parse): Declare.
* Makefile.am (ens32knbsd.c): Depend on netbsd.em.
* Makefile.in: Regenerate.
Index: bfd/coff-i860.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-i860.c,v
retrieving revision 1.13
diff -u -p -r1.13 coff-i860.c
--- bfd/coff-i860.c 24 Nov 2003 18:06:40 -0000 1.13
+++ bfd/coff-i860.c 4 Dec 2003 11:52:09 -0000
@@ -140,6 +140,7 @@ coff_i860_reloc_nyi (bfd *abfd ATTRIBUTE
{
reloc_howto_type *howto = reloc_entry->howto;
fprintf (stderr, _("Relocation `%s' not yet implemented\n"), howto->name);
+ return bfd_reloc_notsupported;
}
#ifndef PCRELOFFSET
Index: bfd/elf-m10300.c
===================================================================
RCS file: /cvs/src/src/bfd/elf-m10300.c,v
retrieving revision 1.45
diff -u -p -r1.45 elf-m10300.c
--- bfd/elf-m10300.c 27 Nov 2003 18:49:37 -0000 1.45
+++ bfd/elf-m10300.c 4 Dec 2003 11:52:16 -0000
@@ -1743,10 +1743,13 @@ elf32_mn10300_finish_hash_table_entry (g
byte_count += 2;
/* Count the insn to allocate stack space too. */
- if (entry->stack_size > 0 && entry->stack_size <= 128)
- byte_count += 3;
- else if (entry->stack_size > 0 && entry->stack_size < 256)
- byte_count += 4;
+ if (entry->stack_size > 0)
+ {
+ if (entry->stack_size <= 128)
+ byte_count += 3;
+ else
+ byte_count += 4;
+ }
/* If using "call" will result in larger code, then turn all
the associated "call" instructions into "calls" instructions. */
@@ -2238,11 +2241,13 @@ mn10300_elf_relax_section (abfd, sec, li
if (sym_hash->movm_args)
bytes += 2;
- if (sym_hash->stack_size && sym_hash->stack_size <= 128)
- bytes += 3;
- else if (sym_hash->stack_size
- && sym_hash->stack_size < 256)
- bytes += 4;
+ if (sym_hash->stack_size > 0)
+ {
+ if (sym_hash->stack_size <= 128)
+ bytes += 3;
+ else
+ bytes += 4;
+ }
/* Note that we've deleted prologue bytes for this
function. */
@@ -2290,11 +2295,13 @@ mn10300_elf_relax_section (abfd, sec, li
if (sym_hash->movm_args)
bytes += 2;
- if (sym_hash->stack_size && sym_hash->stack_size <= 128)
- bytes += 3;
- else if (sym_hash->stack_size
- && sym_hash->stack_size < 256)
- bytes += 4;
+ if (sym_hash->stack_size > 0)
+ {
+ if (sym_hash->stack_size <= 128)
+ bytes += 3;
+ else
+ bytes += 4;
+ }
/* Note that we've deleted prologue bytes for this
function. */
Index: bfd/nlm32-alpha.c
===================================================================
RCS file: /cvs/src/src/bfd/nlm32-alpha.c,v
retrieving revision 1.9
diff -u -p -r1.9 nlm32-alpha.c
--- bfd/nlm32-alpha.c 4 Nov 2003 10:41:52 -0000 1.9
+++ bfd/nlm32-alpha.c 4 Dec 2003 11:52:19 -0000
@@ -97,6 +97,8 @@ nlm_alpha_write_prefix (abfd)
return TRUE;
}
+#define ONES(n) (((bfd_vma) 1 << ((n) - 1) << 1) - 1)
+
/* How to process the various reloc types. */
static reloc_howto_type nlm32_alpha_howto_table[] =
@@ -144,8 +146,8 @@ static reloc_howto_type nlm32_alpha_howt
0, /* special_function */
"REFQUAD", /* name */
TRUE, /* partial_inplace */
- 0xffffffffffffffff, /* src_mask */
- 0xffffffffffffffff, /* dst_mask */
+ ONES (64), /* src_mask */
+ ONES (64), /* dst_mask */
FALSE), /* pcrel_offset */
/* A 32 bit GP relative offset. This is just like REFLONG except
@@ -304,8 +306,8 @@ static reloc_howto_type nlm32_alpha_howt
0, /* special_function */
"SREL64", /* name */
TRUE, /* partial_inplace */
- 0xffffffffffffffff, /* src_mask */
- 0xffffffffffffffff, /* dst_mask */
+ ONES (64), /* src_mask */
+ ONES (64), /* dst_mask */
FALSE), /* pcrel_offset */
/* Push a value on the reloc evaluation stack. */
@@ -336,7 +338,7 @@ static reloc_howto_type nlm32_alpha_howt
"OP_STORE", /* name */
FALSE, /* partial_inplace */
0, /* src_mask */
- 0xffffffffffffffff, /* dst_mask */
+ ONES (64), /* dst_mask */
FALSE), /* pcrel_offset */
/* Subtract the reloc address from the value on the top of the
Index: ld/emultempl/netbsd.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/netbsd.em,v
retrieving revision 1.3
diff -u -p -r1.3 netbsd.em
--- ld/emultempl/netbsd.em 27 Jun 2003 00:38:25 -0000 1.3
+++ ld/emultempl/netbsd.em 4 Dec 2003 11:52:53 -0000
@@ -2,6 +2,9 @@ LDEMUL_BEFORE_PARSE=gldnetbsd_before_par
cat >>e${EMULATION_NAME}.c <<EOF
static void
+gld${EMULATION_NAME}_before_parse (void);
+
+static void
gldnetbsd_before_parse (void)
{
gld${EMULATION_NAME}_before_parse ();
Index: ld/ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.128
diff -u -p -r1.128 ldlang.c
--- ld/ldlang.c 19 Nov 2003 02:40:55 -0000 1.128
+++ ld/ldlang.c 4 Dec 2003 12:01:39 -0000
@@ -3445,7 +3445,7 @@ lang_do_assignments_1
return dot;
}
-bfd_vma
+void
lang_do_assignments (lang_statement_union_type *s,
lang_output_section_statement_type
*output_section_statement,
Index: ld/ldlang.h
===================================================================
RCS file: /cvs/src/src/ld/ldlang.h,v
retrieving revision 1.31
diff -u -p -r1.31 ldlang.h
--- ld/ldlang.h 21 Oct 2003 15:33:47 -0000 1.31
+++ ld/ldlang.h 4 Dec 2003 12:01:39 -0000
@@ -447,7 +447,7 @@ extern void lang_for_each_file
(void (*dothis) (lang_input_statement_type *));
extern void lang_reset_memory_regions
(void);
-extern bfd_vma lang_do_assignments
+extern void lang_do_assignments
(lang_statement_union_type *, lang_output_section_statement_type *,
fill_type *, bfd_vma);
Index: ld/Makefile.am
===================================================================
RCS file: /cvs/src/src/ld/Makefile.am,v
retrieving revision 1.146
diff -u -p -r1.146 Makefile.am
--- ld/Makefile.am 2 Dec 2003 08:14:35 -0000 1.146
+++ ld/Makefile.am 4 Dec 2003 12:04:32 -0000
@@ -1231,7 +1231,8 @@ enews.c: $(srcdir)/emulparams/news.sh \
$(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/aout.sc ${GEN_DEPENDS}
${GENSCRIPTS} news "$(tdir_news)"
ens32knbsd.c: $(srcdir)/emulparams/ns32knbsd.sh \
- $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/aout.sc ${GEN_DEPENDS}
+ $(srcdir)/emultempl/generic.em $(srcdir)/emultempl/netbsd.em \
+ $(srcdir)/scripttempl/aout.sc ${GEN_DEPENDS}
${GENSCRIPTS} ns32knbsd "$(tdir_ns32knbsd)"
eor32.c: $(srcdir)/emulparams/or32.sh \
$(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/or32.sc ${GEN_DEPENDS}
--
Alan Modra
IBM OzLabs - Linux Technology Centre