This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: GAS powerpcle-pe broken
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Wed, 5 Nov 2003 10:04:59 +1030
- Subject: Re: GAS powerpcle-pe broken
- References: <Pine.BSF.4.44.0310191422410.87940-100000@dair.pair.com>
On Sun, Oct 19, 2003 at 02:29:24PM -0400, Hans-Peter Nilsson wrote:
> Looks like all ppc-pe targets are broken in GAS; that function's
Resurrects them. Well, at least they now compile. Testsuite results
aren't very encouraging.
* config/tc-ppc.h (TC_FORCE_RELOCATION): Only define for ELF and XCOFF.
* emultempl/pe.em (gld_${EMULATION_NAME}_after_open): Only do
pe_dll_extra_pe_debug stuff when DLL_SUPPORT defined.
(pr_sym): Move inside #ifdef DLL_SUPPORT.
Index: gas/config/tc-ppc.h
===================================================================
RCS file: /cvs/src/src/gas/config/tc-ppc.h,v
retrieving revision 1.23
diff -u -p -r1.23 tc-ppc.h
--- gas/config/tc-ppc.h 25 Jul 2003 14:35:54 -0000 1.23
+++ gas/config/tc-ppc.h 4 Nov 2003 01:37:25 -0000
@@ -237,8 +237,10 @@ extern void ppc_frob_file_before_adjust
#endif /* OBJ_ELF */
+#if defined (OBJ_ELF) || defined (OBJ_XCOFF)
#define TC_FORCE_RELOCATION(FIX) ppc_force_relocation (FIX)
extern int ppc_force_relocation PARAMS ((struct fix *));
+#endif
/* call md_pcrel_from_section, not md_pcrel_from */
#define MD_PCREL_FROM_SECTION(FIX, SEC) md_pcrel_from_section(FIX, SEC)
Index: ld/emultempl/pe.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/pe.em,v
retrieving revision 1.82
diff -u -p -r1.82 pe.em
--- ld/emultempl/pe.em 31 Oct 2003 05:32:44 -0000 1.82
+++ ld/emultempl/pe.em 4 Nov 2003 11:41:08 -0000
@@ -916,7 +916,6 @@ pe_find_data_imports (void)
}
}
}
-#endif /* DLL_SUPPORT */
static bfd_boolean
pr_sym (struct bfd_hash_entry *h, void *inf ATTRIBUTE_UNUSED)
@@ -926,11 +925,13 @@ pr_sym (struct bfd_hash_entry *h, void *
return TRUE;
}
+#endif /* DLL_SUPPORT */
static void
gld_${EMULATION_NAME}_after_open (void)
{
+#ifdef DLL_SUPPORT
if (pe_dll_extra_pe_debug)
{
bfd *a;
@@ -945,6 +946,7 @@ gld_${EMULATION_NAME}_after_open (void)
for (a = link_info.input_bfds; a; a = a->link_next)
printf ("*%s\n",a->filename);
}
+#endif
/* Pass the wacky PE command line options into the output bfd.
FIXME: This should be done via a function, rather than by
--
Alan Modra
IBM OzLabs - Linux Technology Centre