This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [rfa] make bfd_set_section_contents buffer param constant
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 1 Nov 2003 12:27:05 +1030
- Subject: Re: [rfa] make bfd_set_section_contents buffer param constant
- References: <3FA29A42.5040302@redhat.com>
On Fri, Oct 31, 2003 at 12:22:10PM -0500, Andrew Cagney wrote:
> * section.c (bfd_set_section_contents): Make the "location" buffer
> constant.
> * bfd-in2.h: Re-generate.
OK. Andrew, if you're in cleanup mode can I suggest another worthwhile
cleanup? A bit more work than this one.
In bfd we have a number of places that use a bfd_vma to store/pass data
known to require 64 bit integer types. We ought to use an explicit 64
bit type, as bfd_vma is only 32 bits when configuring for a 32 bit
target (unless you use --enable-64-bit-bfd, which bloats libbfd). One
example of a place that would benefit is dwarf2.c, where we run into an
assert if processing DW_FORM_data8. I can't see anything in the DWARF3
spec that precludes use of data8 and ref8 in a 32 bit ELF file.
--
Alan Modra
IBM OzLabs - Linux Technology Centre