This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH/RFA] Merge non visibility STO attribute
- From: "H. J. Lu" <hjl at lucon dot org>
- To: kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 13 Oct 2003 08:44:06 -0700
- Subject: Re: [PATCH/RFA] Merge non visibility STO attribute
- References: <20031013.232306.55848730.kkojima@rr.iij4u.or.jp>
On Mon, Oct 13, 2003 at 11:23:06PM +0900, kaz Kojima wrote:
> Hi,
>
> I've written a tiny test which calls a function in a shared libirary
> on sh64-elf. It fails because of two problems. The first is an SH
> specific one that some SHmedia relocations aren't handled correctly
> for the dynamic symbol.
> The second problem is that elf_link_add_object_symbols doesn't merge
> any STO attributes of the symbol from a dynamic object. The attached
> patch fixes these and adds the above new test. I've tested the patch
> on i686-pc-linux-gnu and sh64-elf and there are no new regressions.
> OK to the trunk?
>
Since gABI only defines visibility, I don't think elf_link_add_object_symbols
should touch other parts of STO. I think we should have a target
specific way to merge informaton from symbol table entry.
H.J.