Use bfd_map_over_sections in objdump.c

[Nick Clifton <nickc at redhat dot com>]

Hi Guys,

  In a moment of madness I decided to tidy up objdump.c so that it
  used bfd_map_over_sections() to traverse all the sections in a bfd,
  rather than using a for loop.  In the process I also eliminated the
  dumping of sections with no contents, so I had to tweak all of the
  GAS testsuite scripts that looked for empty sections.  The result is
  the attached patch which I am going to apply today.

Cheers
        Nick

binutils/ChangeLog
2003-09-03  Nick Clifton  <nickc@redhat.com>

	* objdump.c (struct objdump_disasm_info): Add new fields
        'dynrelbuf', 'dynrelcount' and 'disassemble_fn'.
        (process_section_p): New function:  Returns TRUE if a section
        can be dumped.
        (disassemble_section): New function: Contains the body of
	disassemble_data(), but just for one section.
        (disassemble_data): Use bfd_map_over_sections to walk section
        chain.
        (find_stabs_section): New function: Find a stabs containing
        section and then dump it.
        (dump_stabs_section): New function: Use bfd_map_over_sections
        to find the section to dump.
        (dump_stabs): Use dump_stabs_section.
        (dump_section): New function: Display the contents of a
        section.
        (dump_data): Use bfd_map_over_sections to display section
        contents.
        (dump_relocs_in_section): Display the relocs in a given section.
        (dump_relocs): Use bfd_map_over_sections to display relocs.
	(adjust_addresses): New function: Adjust the vma and lma of
        sections.
        (dump_bfd): Use bfd_map_over_sections.
        * doc/binutils.texi: Document the "objdump -s" (no longer)
        dumps empty sections.
        
2003-08-24  Jonathan R. Grant  <jg-binutils@jguk.org>

	* objdump.c: Improve comments/documentation.
	dump_data (bfd *abfd): Eliminate duplicate function calls to
	bfd_section_size().

gas/testsuite/ChangeLog
2003-09-03  Nick Clifton  <nickc@redhat.com>

	* gas/cris/diffexp-ovwr.d: Remove regexp for empty section
	contents string.
	gas/cris/pushpop-dcr1-sreg.d: Likewise.
	gas/cris/string-1.d: Likewise.
	gas/cris/string-2.d: Likewise.
	gas/cris/x-to-dcr1-sreg.d: Likewise.
	gas/elf/section0.d: Likewise.
	gas/elf/section1.d: Likewise.
	gas/i386/relax.d: Likewise.
	gas/mips/elempic.d: Likewise.
	gas/mips/empic.d: Likewise.
	gas/mips/mips16-e.d: Likewise.
	gas/mips/mips16-f.d: Likewise.
	gas/mips/mipsel16-e.d: Likewise.
	gas/mips/mipsel16-f.d: Likewise.
	gas/mips/rm7000.d: Likewise.
	gas/mips/telempic.d: Likewise.
	gas/mips/tempic.d: Likewise.
	gas/mips/tmips16-e.d: Likewise.
	gas/mips/tmips16-f.d: Likewise.
	gas/mips/tmipsel16-e.d: Likewise.
	gas/mips/tmipsel16-f.d: Likewise.
	gas/mmix/align-1.d: Likewise.
	gas/mmix/basep-10.d: Likewise.
	gas/mmix/basep-11.d: Likewise.
	gas/mmix/basep-9.d: Likewise.
	gas/mmix/comment-3.d: Likewise.
	gas/mmix/cons-1.d: Likewise.
	gas/mmix/cons-2.d: Likewise.
	gas/mmix/expr-1.d: Likewise.
	gas/mmix/fb-1.d: Likewise.
	gas/mmix/fb-2.d: Likewise.
	gas/mmix/greg1.d: Likewise.
	gas/mmix/greg1a.d: Likewise.
	gas/mmix/greg2.d: Likewise.
	gas/mmix/greg2a.d: Likewise.
	gas/mmix/greg3.d: Likewise.
	gas/mmix/greg4.d: Likewise.
	gas/mmix/greg7.d: Likewise.
	gas/mmix/greg8.d: Likewise.
	gas/mmix/is-1.d: Likewise.
	gas/mmix/local-1.d: Likewise.
	gas/mmix/odd-1.d: Likewise.
	gas/mmix/op-0-1.d: Likewise.
	gas/mmix/op-0-2.d: Likewise.
	gas/mmix/prefix3.d: Likewise.
	gas/mmix/pseudo-1.d: Likewise.
	gas/mmix/weak1.d: Likewise.
	gas/sh/sh64/crange1-1.d: Likewise.
	gas/sh/sh64/crange1-2.d: Likewise.
	gas/sh/sh64/crange2-2.d: Likewise.
	gas/sh/sh64/crange3-1.d: Likewise.
	gas/sh/sh64/crange4-1.d: Likewise.
	gas/sh/sh64/crange5-1.d: Likewise.
	gas/sh/sh64/datal32-3.d: Likewise.
	gas/sh/sh64/datal64-3.d: Likewise.
	gas/sh/sh64/endian-1.d: Likewise.
	gas/sh/sh64/endian-2.d: Likewise.
	gas/sh/sh64/localcom-1.d: Likewise.
	gas/sh/sh64/rel32-5.d: Likewise.
	gas/sh/sh64/rel64-5.d: Likewise.
	gas/sh/sh64/ua32-1.d: Likewise.
	gas/sh/sh64/ua64-1.d: Likewise.
	gas/xstormy16/reloc-1.d: Likewise.

Attachment: objdump.patch.bz2
Description: Tidy up objdump.c