This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: cleanup INIT_DISASSEMBLE_INFO macro


On Wed, Aug 27, 2003 at 03:54:49PM -0400, Andrew Cagney wrote:

Here's a revised patch. It just updates the binutils side and retains backward compatibility. I discovered that the sim directories have a few lotering INIT_DISASSEMBLE_INFO references.


OK.  Hmm, you might like to use a memset in init_disassemble_info
instead of all the zero and NULL assignments.

That gets religious - check the archives. If you really want the change just say the word :-)


Question:  I'd like to stash the results of parsing
disassemble_info.disassembler_options in disassemble_info.private_data.
Saves doing the parsing every call to print_insn.  Is this compatible
with gdb?  ie. Does gdb re-init disassemble_info if the options change?

GDB's disassemble info object isn't static. It is initialized at the start of every disassemble sequence (one or more print instruction calls). GDB <-> opcodes has a number of problems here, though, I'll start a new thread.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]