This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] ld config bits for i860 coff target


On Tue, Aug 05, 2003 at 12:00:31PM -0500, Jason Eckhardt wrote:
>   I found automake-000227.tar.bz2 from the above, which reports
>   it's version 1.4. I must be dense, where is the -p5 version?
>   Or are the diffs with 1.4 below okay?

Heh.

> @@ -785,7 +786,7 @@ uninstall-info:
>  	else ii=; fi; \
>  	list='$(INFO_DEPS)'; \
>  	for file in $$list; do \
> -	  test -z "$$ii" \
> +	  test -z "$ii" \
>  	    || install-info --info-dir=$(DESTDIR)$(infodir) --remove $$file; \
>  	done
>  	@$(NORMAL_UNINSTALL)

This shows a bug in the 000227 version..

> @@ -898,7 +899,7 @@ maintainer-clean-recursive:
>  	dot_seen=no; \
>  	rev=''; list='$(SUBDIRS)'; for subdir in $$list; do \
>  	  rev="$$subdir $$rev"; \
> -	  test "$$subdir" != "." || dot_seen=yes; \
> +	  test "$$subdir" = "." && dot_seen=yes; \
>  	done; \
>  	test "$$dot_seen" = "no" && rev=". $$rev"; \
>  	target=`echo $@ | sed s/-recursive//`; \

Another minor bug.

> @@ -1079,7 +1080,7 @@ distclean-generic:
>  	-test -z "$(DISTCLEANFILES)" || rm -f $(DISTCLEANFILES)
> 
>  maintainer-clean-generic:
> -	-test -z "ldlex.cdeffilep.hdeffilep.cldgram.hldgram.c$(MAINTAINERCLEANFILES)" || rm -f ldlex.c deffilep.h deffilep.c ldgram.h ldgram.c $(MAINTAINERCLEANFILES)
> +	-test -z "ldlexldeffilephdeffilepcldgramhldgramc$(MAINTAINERCLEANFILES)" || rm -f ldlexl deffileph deffilepc ldgramh ldgramc $(MAINTAINERCLEANFILES)
>  mostlyclean-am:  mostlyclean-hdr mostlyclean-noinstPROGRAMS \
>  		mostlyclean-compile mostlyclean-libtool \
>  		mostlyclean-aminfo mostlyclean-tags mostlyclean-generic \

Another bug.  rm -f ldlexl deffileph ... isn't exactly what we want.

It's well past time that binutils blessed newer versions of autoconf
and automake.  There was a patch some time ago to update to autoconf 2.5
but that never got applied.  See
http://sources.redhat.com/ml/binutils/2003-01/msg00143.html

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]