This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Adding '.set' pseudo op for ppc - first draft
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Jeff Baker <jbaker at qnx dot com>
- Cc: "'binutils at sources dot redhat dot com'" <binutils at sources dot redhat dot com>
- Date: Thu, 19 Jun 2003 13:53:35 -0400
- Subject: Re: [PATCH] Adding '.set' pseudo op for ppc - first draft
- References: <1578FF984ABAD411AFA5000102C4BB5B02CB9081@nimbus>
On Thu, Jun 19, 2003 at 01:30:41PM -0400, Jeff Baker wrote:
> This is my first draft at adding the .set pseudo op for ppc.
>
> gas/ChangeLog:
>
> 2003-06-19 Jeff Baker jbaker@qnx.com
>
> * config/tc-ppc.c: (ppc_set_cpu_value) New Function.
> (ppc_set) New Function.
> (md_parse_option) Uses ppc_set_cpu_value to help parse -m options.
>
First of all, please use diff -up or -cp. Diff output is not useful
otherwise.
Secondly, this must have testcases.
Third, have you really tried it? Please re-read Alan's comment when
you first suggested this, about md_begin (). Then take a good look at
that function. Your code will not work as-is.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer