This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adding '.set' pseudo op for ppc - first draft


On Thu, Jun 19, 2003 at 01:30:41PM -0400, Jeff Baker wrote:
> This is my first draft at adding the .set pseudo op for ppc.
> 
> gas/ChangeLog:
> 
> 2003-06-19  Jeff Baker jbaker@qnx.com
> 
> 	* config/tc-ppc.c: (ppc_set_cpu_value) New Function.
> 	(ppc_set) New Function.	
> 	(md_parse_option) Uses ppc_set_cpu_value to help parse -m options.
> 

First of all, please use diff -up or -cp.  Diff output is not useful
otherwise.

Secondly, this must have testcases.

Third, have you really tried it?  Please re-read Alan's comment when
you first suggested this, about md_begin ().  Then take a good look at
that function.  Your code will not work as-is.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]