This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFA: Revert recent s_cprestore patch
- From: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- To: Richard Sandiford <rsandifo at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 19 Jun 2003 18:45:18 +0200
- Subject: Re: RFA: Revert recent s_cprestore patch
- References: <wvnbrwvn4ll.fsf@talisman.cambridge.redhat.com>
Richard Sandiford wrote:
>
> Thiemo, what was the motivation for this patch?
A dumb thinko. :-)
> 2003-06-11 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> * config/tc-mips.c (s_cpsetup): Use mips_frame_reg instead of SP.
> (s_cprestore): Likewise.
> (s_cpreturn): Likewise.
>
> It introduces an incompatibility with previous binutils releases, and with
> the SGI assemblers, both of which use $sp rather than the frame pointer
> for these macros. And the change to .cprestore breaks mips-linux-gnu-gcc,
> which uses .cprestore before the frame pointer has been set up.
>
> Is it OK to revert the patch?
I did so. Thanks for spotting this.
Thiemo