This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] updated GNU/FreeBSD patch for latest binutils
- From: Nick Clifton <nickc at redhat dot com>
- To: Robert Millan <zeratul2 at wanadoo dot es>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 30 May 2003 08:59:09 +0100
- Subject: Re: [PATCH] updated GNU/FreeBSD patch for latest binutils
- References: <20030513141610.GA8071@khazad.dyndns.org><m3k7cv6pg9.fsf@redhat.com> <20030521153610.GA4219@aragorn><m3y90zgwmy.fsf@redhat.com> <20030523155908.GA6349@aragorn><m3n0hd3a8k.fsf@redhat.com> <20030525022156.GA11408@aragorn><m3smqy12lm.fsf@redhat.com> <20030529160545.GB664@aragorn><m3k7c9wrqx.fsf@redhat.com> <20030530001946.GA863@aragorn>
Hi Robert,
>> I am applying the patch below to fix this.
>> [...]
>>
>> + i386-*-freebsd*) fmt=elf em=freebsd ;;
>
> I think that should be 'i386-*-freebsd*-gnu*',
I based the regexp in my patch on the version used in bfd/config.bfd:
i[3-7]86-*-freebsd*)
targ_defvec=bfd_elf32_i386_freebsd_vec
targ_selvecs=i386coff_vec
# FreeBSD <= 4.0 supports only the old nonstandard way of ABI labelling.
case "${targ}" in
i[3-7]86-*-freebsd3* | i[3-7]86-*-freebsd4 | i[3-7]86-*-freebsd4.0*)
targ_cflags=-DOLD_FREEBSD_ABI_LABEL ;;
esac
;;
> otherwise it will be caught by native FreeBSD (iirc, FreeBSD 5.0 is
> 'i386-*-freebsd5.0')
It was a discrepancy between config.bfd and gas/configure.in that was
causing the bug you encountered. I think that the two files are now
in sync, so if we need to change one we must change the other as well,
(and ld/configure.tgt).
> After patching a bunch of triplet test cases for adding freebsd-gnu,
> i found that a practical solution is to add freebsd-gnu before any other
> freebsd, then the native freebsd's, eg:
>
> freebsd*-gnu*) foo;;
> freebsd1) bar;;
> freebsd*) toe;;
I would prefer to have to have some verification that the current
versions of the configuration files are broken for native FreeBSD
systems before we go changing them again.
Cheers
Nick