Re: [RFA] CFI improvements

[amodra at bigpond dot net dot au]

On Wed, May 21, 2003 at 06:44:14PM +0200, Michal Ludvig wrote:
> +      if ((value = tc_regname_to_dw2regnum (input_line_pointer, &size)) >= 0)
> +      {

Here and other places you indent braces incorrectly.  Please fix.

> -      regnames_count = sizeof (regnames_64);
> +      regnames_count = sizeof (regnames_64) / sizeof (void*);

Better to divide by sizeof (regnames_64[0]), then it's obvious in
just this one line of code that you're calculating an array size.

> -      regnames_count = sizeof (regnames_32);
> +      regnames_count = sizeof (regnames_32) / sizeof (void*);

Same thing here.

> +  while ((*p >= 'a' && *p <= 'z') 
> +	 || (*p >= 'A' && *p <= 'Z')
> +	 || (*p >= '0' && *p <= '9'))

while (ISALNUM (*p))

> +  /* Save char at *p only when it isn't \0.  */

Why not save it when it is 0 too?  Saves a test, here and later when
you restore.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre