This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] fix ld segv on alpha during gal compilation
On Mon, Apr 21, 2003 at 11:25:30AM -0700, Richard Henderson wrote:
> This is incorrect. srel->contents should not have been null.
> The fix needs to happen somewhere else.
Like so.
r~
* elf64-alpha.c (alpha_elf_dynamic_symbol_p): Return false for an
executable when a symbol is defined both regular and dynamic.
Index: elf64-alpha.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-alpha.c,v
retrieving revision 1.96
diff -c -p -d -u -r1.96 elf64-alpha.c
--- elf64-alpha.c 9 Apr 2003 20:08:14 -0000 1.96
+++ elf64-alpha.c 21 Apr 2003 22:15:22 -0000
@@ -305,7 +305,9 @@ alpha_elf_dynamic_symbol_p (h, info)
if ((info->shared && !info->symbolic)
|| ((h->elf_link_hash_flags
- & (ELF_LINK_HASH_DEF_DYNAMIC | ELF_LINK_HASH_REF_REGULAR))
+ & (ELF_LINK_HASH_DEF_DYNAMIC
+ | ELF_LINK_HASH_DEF_REGULAR
+ | ELF_LINK_HASH_REF_REGULAR))
== (ELF_LINK_HASH_DEF_DYNAMIC | ELF_LINK_HASH_REF_REGULAR)))
return TRUE;