This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH/cygwin: Don't pollute namespace with 'end' inld/scripttempl/pe.sc (take 2]
- From: Danny Smith <dannysmith at clear dot net dot nz>
- To: binutils <binutils at sources dot redhat dot com>
- Cc: Ian Lance Taylor <ian at airs dot com>
- Date: Sun, 02 Mar 2003 21:35:58 +0000
- Subject: Re: PATCH/cygwin: Don't pollute namespace with 'end' inld/scripttempl/pe.sc (take 2]
- References: <001001c2e0aa$3dd4e5e0$ec90a7cb@DANNY><m33cm5hfrn.fsf@gossamer.airs.com>
- Reply-to: Danny Smith <dannysmith at users dot sourceforge dot net>
From: "Ian Lance Taylor" <ian at airs dot com>
To: "Danny Smith" <dannysmith at users dot sourceforge dot net>
Cc: "binutils" <binutils at sources dot redhat dot com>
Sent: Sunday, 2 March 2003 16:53
Subject: Re: PATCH/cygwin: Don't pollute namespace with 'end' in
ld/scripttempl/pe.sc
> Danny Smith <dannysmith at clear dot net dot nz> writes:
>
> > The following fixes PR 5563 in the GCC GNATS database:
> > [Cygwin] using a pointer named "end" consistently produces segfault
in
> > windows.
>
> It may be better to use PROVIDE, so that there is some backward
> compatibility.
>
> Ian
Thanks, I didn't know about PROVIDE.
Danny
ld/ChangeLog
2003-03-02 Danny Smith <dannysmith at users dot sourceforge dot net>
* scripttempl/pe.sc: Use PROVIDE with etext, end, _end,
Index: src/ld/scripttempl/pe.sc
===================================================================
RCS file: /cvs/src/src/ld/scripttempl/pe.sc,v
retrieving revision 1.7
diff -c -3 -p -r1.7 pe.sc
*** src/ld/scripttempl/pe.sc 23 Oct 2002 11:21:27 -0000 1.7
--- src/ld/scripttempl/pe.sc 2 Mar 2003 20:51:16 -0000
*************** SECTIONS
*** 60,66 ****
${RELOCATING+ *(.fini)}
/* ??? Why is .gcc_exc here? */
${RELOCATING+ *(.gcc_exc)}
! ${RELOCATING+ etext = .;}
*(.gcc_except_table)
}
--- 60,66 ----
${RELOCATING+ *(.fini)}
/* ??? Why is .gcc_exc here? */
${RELOCATING+ *(.gcc_exc)}
! ${RELOCATING+PROVIDE (etext = .);}
*(.gcc_except_table)
}
*************** SECTIONS
*** 132,139 ****
.endjunk ${RELOCATING+BLOCK(__section_alignment__)} :
{
/* end is deprecated, don't use it */
! ${RELOCATING+ end = .;}
! ${RELOCATING+ _end = .;}
${RELOCATING+ __end__ = .;}
}
--- 132,139 ----
.endjunk ${RELOCATING+BLOCK(__section_alignment__)} :
{
/* end is deprecated, don't use it */
! ${RELOCATING+PROVIDE (end = .);}
! ${RELOCATING+PROVIDE ( _end = .);}
${RELOCATING+ __end__ = .;}
}