This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: vxWorks-style symbol table extraction.


Hi Sean,

> The patch below add support to binutils to generate vxWorks-style
> symbol table files.  Can this be incorporated into binutils?

Thanks very much for submitting this patch.  Unfortunately since this
is not a trivial change, it does mean that you must fill out an FSF
copyright assignment before we can accept the patch.  Please could you
fill out and send off the attached form ?

I also have a couple of minor comments on the patch as well:

> + /* Flag for extract symbol option */

Please try to follow the GNU coding conventions.  In particular please
comments as English sentences and end them with a full stop followed
by two spaces.  There are several places in your patch where the
comments need to be changed.

> +   {"extract-symbol", no_argument, 0, OPTION_EXTRACT_SYMBOL},

Since you are adding a new feature to the objcopy program, please
could you also update the documentation (doc/binutils.texi) and the
NEWS file as well.  It would also be nice if you could add a test to
the binutils testsuite to make sure that the feature works and
continues to work in the future.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]