This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: The Linux binutils 2.13.90.0.18 is rleased


On Sun, Feb 09, 2003 at 01:57:59AM +0100, Olaf Hering wrote:
>  On Sat, Feb 08, Olaf Hering wrote:
> 
> >  On Sat, Feb 08, Jakub Jelinek wrote:
> > 
> > > On Sat, Feb 08, 2003 at 07:53:01PM +0100, Olaf Hering wrote:
> > > > > I have no problems with x86. It seems that PPC is broken. Alan, what
> > > > > do you get on PPC?
> > > > 
> > > > Yes, something is broken on ppc32.
> > > > I tried glibc CVS from 20021215 (also with binutils 2.13.90.0.10) and it
> > > > has the same make check failure.
> > > > I wonder how glibc ever passed make check in the last 6 weeks...
> > > 
> > > Probably depends on the compiler, because it passes for me just fine
> > > (both with binutils 2.13.90.0.16 and 2.13.90.0.18, gcc-3_2-rhl8-branch
> > > in both cases).
> > 
> > I have tried 3.2 and 3.2.2. It seems I have to investigate now.
> 
> Yes, glibc make check passes with gcc-3_2-rhl8-branch but not with
> gcc-3_2-branch.
> I found nothing obvious in the diff. What part does fix it?

I haven't looked at any diffs redhat might be using, but try this:

	* sysdeps/powerpc/powerpc32/sysdep.h (HIDDEN_JUMPTARGET): Redefine.

Index: sysdeps/powerpc/powerpc32/sysdep.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/powerpc/powerpc32/sysdep.h,v
retrieving revision 1.3
diff -u -p -r1.3 sysdep.h
--- sysdeps/powerpc/powerpc32/sysdep.h	9 Jan 2003 19:46:46 -0000	1.3
+++ sysdeps/powerpc/powerpc32/sysdep.h	11 Feb 2003 22:53:40 -0000
@@ -111,6 +111,12 @@
 #define JUMPTARGET(name) name
 #endif
 
+#if defined SHARED && defined DO_VERSIONING && defined PIC \
+    && !defined HAVE_BROKEN_ALIAS_ATTRIBUTE && !defined NO_HIDDEN
+#undef HIDDEN_JUMPTARGET
+#define HIDDEN_JUMPTARGET(name) __GI_##name##@local
+#endif
+
 #define PSEUDO(name, syscall_name, args)				      \
   .section ".text";							      \
   ENTRY (name)								      \

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]