This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix s390 as
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Martin Schwidefsky <schwidefsky at de dot ibm dot com>, <binutils at sources dot redhat dot com>
- Date: Wed, 22 Jan 2003 20:01:22 -0500 (EST)
- Subject: Re: [PATCH] Fix s390 as
On Thu, 23 Jan 2003, Alan Modra wrote:
> On Wed, Jan 22, 2003 at 11:39:36PM +1030, Alan Modra wrote:
> > #define TC_FORCE_RELOCATION_SUB_SAME(FIX, SEG) \
> > (! SEG_NORMAL (SEG) || TC_FORCE_RELOCATION (FIX))
>
> Breaks gas/testsuite/gas/cris/binop-segref.s
I'm not totally sure about the test-case. It includes
subtraction of two global symbols. This *is* actually fine
provided they are *not* supposed to be overridden by other
objects (as expected when producing a DSO).
I think the globalness of a subtractive symbol was deemed to be
ignored for a similar case for x86 some time ago, which leaves
the globalness of the additive symbol, which isn't changed into
a PC-relative reloc for CRIS, but instead an error case.
Altogether, I lean towards a specific
TC_FORCE_RELOCATION_SUB_SAME for CRIS.
brgds, H-P