This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix s390 as
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Schwidefsky <schwidefsky at de dot ibm dot com>
- Cc: amodra at bigpond dot net dot au, binutils at sources dot redhat dot com
- Date: Wed, 22 Jan 2003 13:21:33 +0100
- Subject: Re: [PATCH] Fix s390 as
- References: <OFEADB4B81.205E928C-ONC1256CB6.0034DC10@de.ibm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jan 22, 2003 at 10:56:23AM +0100, Martin Schwidefsky wrote:
>
> Hi Jakub,
>
> >The problem is that assembler relocates f1@PLT-.LT1 into constant
> >instead of emitting relocation for the linker (note that f1
> >is global symbol and as such should be overridable in another shared
> >library etc.).
>
> Some four letter words come to mind. Just tested with 2.12.90.0.15
> and luckily this version doesn't show the problem (relevant for the
> current s390 distributions). I wonder since when this problem has
> been there.
At least TC_FORCE_RELOCATION_SUB_SAME was introduced with Alan's
2002-09-05 patch. It is already in hjl's 2.13.90.0.16.
Now, thinking about debug info, AFAIK debug info doesn't contain
subtractions of global symbol and local one in the same section,
it always uses .L*-. etc. instead, so !S_IS_EXTERNAL
before !TC_FORCE_RELOCATION_SUB_SAME IMHO really
shouldn't hurt.
Jakub