This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Unreviewed patch
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jason R Thorpe <thorpej at wasabisystems dot com>, binutils at sources dot redhat dot com
- Date: Wed, 4 Dec 2002 16:03:02 +1030
- Subject: Re: Unreviewed patch
- References: <20021127201637.GA7228@yeah-baby.shagadelic.org>
! else if ((s->flags & (SEC_CODE | SEC_READONLY)) == SEC_READONLY)
! {
! /* If we have .rodata, fine. If not, assume we can put read-only
! data into .text. */
! place = HAVE_SECTION (hold_rodata, ".rodata") ? &hold_rodata
! : &hold_text;
! }
Hmm, we had this behaviour before I took it out on 2000-09-07. I can't
remember the details now. :-(
+ /* By sorting the orphan after place->os, we effectively changed
+ the size of that section. Adjust the size of the section to
+ reflect the additional output. */
This I don't like. An orphan goes into its own output section. It's
wrong to adjust the size of the previous non-orphan output section.
--
Alan Modra
IBM OzLabs - Linux Technology Centre