This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA] Relocations in dwarf2, 2nd attempt
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Michal Ludvig <mludvig at suse dot cz>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 29 Oct 2002 09:58:10 -0500
- Subject: Re: [RFA] Relocations in dwarf2, 2nd attempt
- References: <3DBE9F16.9080105@suse.cz>
On Tue, Oct 29, 2002 at 03:45:42PM +0100, Michal Ludvig wrote:
> drow@mvista.com wrote:
>
> > There's code in bfd/simple.c you can use to relocate a section if
> > that's what you want.
>
> Thanks for a hint! It simplified my patch "a little".
> (however simple.c is pretty new, isn't it?)
Yes. This is one of the two things I added it for :) I just never had
time to finish it.
> Could someone approve it now, please?
Two problems:
- You introduce long lines.
- Please add a fast-path exit from bfd_simple_get_relocated_section_contents
that just calls bfd_get_section_contents if ! SEC_RELOC.
Other than that, it looks good to me, but someone else will have to
approve it.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer