RE: [Patch] sh64: Fix refcounting for SHmedia

["Clarke, Stephen" <stephen dot clarke at superh dot com>]

> From: Alan Modra
> Sent: Friday, October 11, 2002 2:34 AM
> On Thu, Oct 10, 2002 at 04:58:23PM -0700, Clarke, Stephen wrote:
> > *************** sh_elf_link_hash_newfunc (entry, table, 
> [...]
> You should get rid of "eh" here as "ret" and "eh" have the same type.
> Also, avoid a cast by writing
> 
>       ret->datalabel_got.refcount = ret->root.got.refcount;
> 
> Other than that, the patch looks good to me.

Here's the revised patch.  I've cleaned up
sh_elf_link_hash_newfunc as requested, and remade the whole patch
now that the tls support has been merged in.

The code in allocate_dynrelocs and sh_elf_finish_dynamic_symbol will
almost certainly require extra work when tls is extended to sh64, but
I've treated that as out of the scope of this patch - it requires an
understanding of the interraction between datalabel and tls.

Steve.

Attachment: datalabel-got-patch.gz
Description: datalabel-got-patch.gz