This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Patch] sh64: Fix gas testsuite expected output
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Stephen Clarke <stephen dot clarke at earthling dot net>
- Cc: "H. J. Lu" <hjl at lucon dot org>, <binutils at sources dot redhat dot com>
- Date: Thu, 10 Oct 2002 00:20:35 -0400 (EDT)
- Subject: Re: [Patch] sh64: Fix gas testsuite expected output
On Wed, 9 Oct 2002, Stephen Clarke wrote:
> From: "Hans-Peter Nilsson"
> Subject: Re: [Patch] sh64: Fix gas testsuite expected output
> > --- ld/testsuite/ld-sh/sh.exp 30 Aug 2002 00:51:57 -0000
> > ! if { ([istarget sh64-*-elf]
> > ! || [istarget sh64*-*-linux*])} {
> > I'd rather you tweak the target specifiers on the tests:
> > #targets: sh-*-* shl*-*-* shb*-*-*
> > in each *.d should suffice.
>
> It turns out that only ld-r-1.d matches
> the sh64*-*-linux* target - none of the other *.d match
> any linux configuration.
>
> But I'm a bit nervous about the exact change you suggest,
> because I thought sh[1234]-linux were supported
> targets?
Right.
> How about the following instead:
> Index: ld-r-1.d
> #target: sh*-*-elf sh*-*-linux*
> + #notarget: sh64*-*-linux*
Yes, using "notarget" (doh, missed that one) is fine of course.
As long as the target exclusion is in each test rather than
before the whole test-loop.
brgds, H-P