This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testcase] bug caused by the orphan .rel placement patch


On Wed, Oct 09, 2002 at 10:35:27PM +0200, Jakub Jelinek wrote:
> On Mon, Sep 30, 2002 at 12:58:50PM +0930, Alan Modra wrote:
> > ld/ChangeLog
> > 	* emultempl/elf32.em (output_rel_find): Always place orphan loadable
> > 	reloc sections just before .rel.plt/.rela.plt.
> > 	(gld${EMULATION_NAME}_place_orphan <.rel>): Remove combreloc code.
> > 	Only put loadable reloc sections in hold_rel.
> 
> Unfortunately this patch broke the following testcase (distilled
> from glibc).
> Guess the combreloc code should not have removed.

Bah.  No use of .rel.dyn before the orphan, and .rela.dyn is
immediately before .rel.plt.  So we use .rela.dyn.  Yes?  Maybe
I should run the testcase.  :)

> 2002-10-09  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* ld-i386/combreloc.s: New test.
> 	* ld-i386/combreloc.d: New test.
> 	* ld-i386/i386.exp (i386tests): Add it.

Please install.  I'll have a fix in a few minutes, and testing will
take a few minutes more.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]