This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [testcase] bug caused by the orphan .rel placement patch
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 10 Oct 2002 09:54:20 +0930
- Subject: Re: [testcase] bug caused by the orphan .rel placement patch
- References: <200209291441.KAA01834@bromo.msbb.uc.edu> <20020929170140.A25376@lucon.org> <20020930110026.G5311@bubble.sa.bigpond.net.au> <20020930125850.J5311@bubble.sa.bigpond.net.au> <20021009223527.S3451@sunsite.ms.mff.cuni.cz>
On Wed, Oct 09, 2002 at 10:35:27PM +0200, Jakub Jelinek wrote:
> On Mon, Sep 30, 2002 at 12:58:50PM +0930, Alan Modra wrote:
> > ld/ChangeLog
> > * emultempl/elf32.em (output_rel_find): Always place orphan loadable
> > reloc sections just before .rel.plt/.rela.plt.
> > (gld${EMULATION_NAME}_place_orphan <.rel>): Remove combreloc code.
> > Only put loadable reloc sections in hold_rel.
>
> Unfortunately this patch broke the following testcase (distilled
> from glibc).
> Guess the combreloc code should not have removed.
Bah. No use of .rel.dyn before the orphan, and .rela.dyn is
immediately before .rel.plt. So we use .rela.dyn. Yes? Maybe
I should run the testcase. :)
> 2002-10-09 Jakub Jelinek <jakub@redhat.com>
>
> * ld-i386/combreloc.s: New test.
> * ld-i386/combreloc.d: New test.
> * ld-i386/i386.exp (i386tests): Add it.
Please install. I'll have a fix in a few minutes, and testing will
take a few minutes more.
--
Alan Modra
IBM OzLabs - Linux Technology Centre