This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Skip the test if the cross binary fails to run.
- From: Geoff Keating <geoffk at geoffk dot org>
- To: ian at airs dot com
- Cc: hjl at lucon dot org, binutils at sources dot redhat dot com
- Date: Tue, 1 Oct 2002 12:19:23 -0700
- Subject: Re: PATCH: Skip the test if the cross binary fails to run.
- References: <20020930140813.B4494@lucon.org><jmheg7ungg.fsf@desire.geoffk.org> <20020930153004.A5813@lucon.org><200209302322.g8UNMJB02028@desire.geoffk.org><20020930163429.A6702@lucon.org><200210011830.g91IUdq02961@desire.geoffk.org> <m3smzqxb1w.fsf@gossamer.airs.com>
> Mail-Followup-To: hjl@lucon.org, binutils@sources.redhat.com,
> geoffk@geoffk.org
> Cc: hjl@lucon.org, binutils@sources.redhat.com
> From: Ian Lance Taylor <ian@airs.com>
> Date: 01 Oct 2002 11:34:51 -0700
> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
> X-OriginalArrivalTime: 01 Oct 2002 18:35:16.0953 (UTC) FILETIME=[49C6F490:01C26979]
>
> Geoff Keating <geoffk@geoffk.org> writes:
>
> > > Date: Mon, 30 Sep 2002 16:34:29 -0700
> > > From: "H. J. Lu" <hjl@lucon.org>
> >
> > > Because it depends on if I have the cross compiler installed or
> > > not. Why should it become an ERROR just because I have the cross
> > > compiler?
> >
> > It should be an ERROR if you don't have a cross compiler, too, since
> > then the test can't work at all. Certainly, if you have no compiler
> > at all, it's important that the testsuite complains very loudly.
>
> In my opinion, if you don't have a cross-compiler, it should be
> UNTESTED.
>
> The absence of a cross-compiler does not in any way indicate a problem
> with either the tool or the testsuite. It indicates a test which can
> not be run, and that is what UNTESTED means.
Sure. The important thing is that the test doesn't get silently not
run because of a misconfiguration.
--
- Geoffrey Keating <geoffk@geoffk.org>