This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Error in output of readelf
- From: Nick Clifton <nickc at redhat dot com>
- To: ross dot alexander at uk dot neceur dot com
- Cc: binutils at sources dot redhat dot com
- Date: 16 Aug 2002 15:41:41 +0100
- Subject: Re: Error in output of readelf
- References: <OFA017F1CA.DD8DCBF4-ON80256C16.003FAAF8@uk.neceur.com>
Hi Ross,
> readelf does put \n on the end of unknown dynamic entries.
I assume that you mean "does not put \n"...
> Is this a feature or a bug?
A bug. Fixed by applying the patch below.
> Also, should OS specific DT entries be put into readelf?
Yes. There is already code in there to support displaying MIPS and
PARISC specific entries.
Cheers
Nick
2002-08-16 Nick Clifton <nickc@redhat.com>
* readelf.c (process_dynamic_segment): Put a newline after display
an unknown dynamic type.
Index: binutils/readelf.c
===================================================================
RCS file: /cvs/src/src/binutils/readelf.c,v
retrieving revision 1.169
diff -c -3 -p -w -r1.169 readelf.c
*** binutils/readelf.c 15 Aug 2002 12:22:39 -0000 1.169
--- binutils/readelf.c 16 Aug 2002 14:36:53 -0000
*************** process_dynamic_segment (file)
*** 4951,4956 ****
--- 4951,4958 ----
putchar ('\n');
}
}
+ else
+ putchar ('\n');
break;
}
}