This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [hjl@lucon.org: Re: PATCH: Output dwarf debug info only when needed]


Hi Daniel,

> > Also, shouldn't the test for the number of files be either
> > "files_in_use <= 1" or "files_in_use < 2" ?
> 
> Actually, upon thinking about it, I think the files_in_use check should
> be removed.  The "first" file in GCC is numbered '1', which will make
> files_in_use == 2.  But even if there is more than one '.file'
> directive, if there are no .loc directives I don't see how the
> .debug_file section serves any purpose...

Good point :-)

Well let's wait a day to see if anyone else has any comments, and if
not then please consider your modified patch approved.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]