This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: missing quotes in configure
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Igor Schein <igor at txc dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 21 Jun 2002 12:12:23 +0930
- Subject: Re: missing quotes in configure
- References: <20020620200106.GE13221@txc.com>
On Thu, Jun 20, 2002 at 04:01:06PM -0400, Igor Schein wrote:
> --- binutils/configure~ Thu May 9 10:49:17 2002
> +++ binutils/configure Thu Jun 20 14:34:48 2002
> @@ -5006,12 +5006,12 @@
> fi
>
> echo "$ac_t""$bu_cv_have_fopen64" 1>&6
> -if test $bu_cv_have_fopen64 != no; then
> +if test "$bu_cv_have_fopen64" != no; then
> cat >> confdefs.h <<\EOF
> #define HAVE_FOPEN64 1
> EOF
>
> - if test $bu_cv_have_fopen64 = "need -D_LARGEFILE64_SOURCE"; then
> + if test "$bu_cv_have_fopen64" = "need -D_LARGEFILE64_SOURCE"; then
> cat >> confdefs.h <<\EOF
> #define _LARGEFILE64_SOURCE 1
> EOF
Thanks. You should be patching configure.in though. I committed the
following:
binutils/ChangeLog
2002-06-21 Igor Schein <igor@txc.com>
* configure.in: Quote bu_cv_have_fopen64.
* configure: Regenerate.
Index: binutils/configure.in
===================================================================
RCS file: /cvs/src/src/binutils/configure.in,v
retrieving revision 1.33
diff -u -p -r1.33 configure.in
--- binutils/configure.in 21 Jun 2002 02:34:37 -0000 1.33
+++ binutils/configure.in 21 Jun 2002 02:40:31 -0000
@@ -115,10 +115,10 @@ bu_cv_have_fopen64="need -D_LARGEFILE64_
bu_cv_have_fopen64=no)
CPPFLAGS=$saved_CPPFLAGS])])
AC_MSG_RESULT($bu_cv_have_fopen64)
-if test $bu_cv_have_fopen64 != no; then
+if test "$bu_cv_have_fopen64" != no; then
AC_DEFINE([HAVE_FOPEN64], 1,
[Is fopen64 available?])
- if test $bu_cv_have_fopen64 = "need -D_LARGEFILE64_SOURCE"; then
+ if test "$bu_cv_have_fopen64" = "need -D_LARGEFILE64_SOURCE"; then
AC_DEFINE([_LARGEFILE64_SOURCE], 1,
[Enable LFS])
fi
--
Alan Modra
IBM OzLabs - Linux Technology Centre