This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add -S/--print-size to nm


Hi H.J.

> I'd like to check in this patch to fix nm. Any comments?

This patch looks good to me.  (And I apologise for not thinking of
this at the time that I approved the original patch).

One thing though,  There is a second place where the size is display
and which should be controlled by your new switch.  See lines 1504 -
1508.

> 2002-06-15  H.J. Lu  (hjl@gnu.org)
> 
> 	* nm.c (print_size): New variable. Initialize to 0.
> 	(long_options): Add 'S'/"print-size".
> 	(main): Handle 'S'.
> 	(print_symbol_info_bsd): Print size only if print_size is not
> 	0.
> 
> 	* doc/binutils.texi: Document -S/--print-size.

Approved - please apply.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]