This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gas/read.c memory leak fix

From: Elias Athanasopoulos <eathan at otenet dot gr>
To: Nick Clifton <nickc at cambridge dot redhat dot com>
Cc: binutils at sources dot redhat dot com
Date: Wed, 12 Jun 2002 17:56:48 +0300
Subject: Re: [PATCH] gas/read.c memory leak fix
References: <20020611214424.F17527@neutrino.particles.org> <m3sn3smvxh.fsf@north-pole.nickc.cambridge.redhat.com>

On Wed, Jun 12, 2002 at 03:08:26PM +0100, Nick Clifton wrote:

> It's not.  input_scrub_new_file() records the filename in
> physical_input_file, and input_file_open records it in file_name.  To
> make the patch safe you would have to add xstrdup()s to both of these
> and then arrange for the extra memory to be freed at the right time.

Yeap. That is exactly what I was afraid of, but I thought it was best
to have the official confirmation. :-)

I'll have a look at physical_input_file and input_file_open and maybe
come again with a new version.

Elias

-- 
http://gnewtellium.sourceforge.net			MP3 is not a crime.

References:
- [PATCH] gas/read.c memory leak fix
  - From: Elias Athanasopoulos
- Re: [PATCH] gas/read.c memory leak fix
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]