Re: [PATCH] Improved elf linker error message

[Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>]

Tom Rix wrote:
[snip]
> The BFD_ASSERT is now unreachable and should be removed.

I updated the patch accordingly.


Thiemo


2002-05-14  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>

	/bfd/ChangeLog
	* elflink.h (elf_link_output_relocs): Improve error message.


diff -BurpNX /bigdisk/src/binutils-exclude source-orig/bfd/elflink.h source/bfd/elflink.h
--- source-orig/bfd/elflink.h	Fri May 10 21:34:03 2002
+++ source/bfd/elflink.h	Tue May 14 16:37:20 2002
@@ -6283,8 +6283,15 @@ elf_link_output_relocs (output_bfd, inpu
       output_rel_hdr = elf_section_data (output_section)->rel_hdr2;
       rel_countp = &elf_section_data (output_section)->rel_count2;
     }
-
-  BFD_ASSERT (output_rel_hdr != NULL);
+  else
+    {
+      (*_bfd_error_handler) (
+        _("%s: relocation size mismatch in %s section %s"),
+        bfd_get_filename (output_bfd),
+        bfd_get_filename (input_section->owner),
+        input_section->name);
+      abort();
+    }
 
   bed = get_elf_backend_data (output_bfd);
   irela = internal_relocs;