This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: patch, ppc gas xcoff64 minimal toc
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Tom Rix <trix at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 11 Feb 2002 21:19:20 -0500
- Subject: Re: patch, ppc gas xcoff64 minimal toc
- References: <3C6820B6.D520050A@redhat.com> <3C686165.D5716936@redhat.com>
Yes, thank you.
On Mon, Feb 11, 2002 at 06:27:17PM -0600, Tom Rix wrote:
> May I also commit this to the 2.12 branch?
>
> Tom
>
> > Sorry I did not catch this on sooner...
> >
> > 64bit minimal toc fails because of this line in tc-ppc, md_apply_fix3.
> > Checking for a null file op for 32bit is ok because l uses the d field
> > but for 64 bit ld uses the ds field and has a mostly trivial insert file
> > op.
> >
> > Tom
> >
> > --
> > Tom Rix
> > GCC Engineer
> > trix@redhat.com
> >
> > ------------------------------------------------------------------------
> > 2002-02-11 Tom Rix <trix@redhat.com>
> >
> > * config/tc-ppc.c (md_apply_fix3): Check for insert fop invalid for
> > xcoff64.
> >
> > diff -rcp src-old/gas/config/tc-ppc.c src/gas/config/tc-ppc.c
> > *** src-old/gas/config/tc-ppc.c Mon Feb 11 10:16:41 2002
> > --- src/gas/config/tc-ppc.c Mon Feb 11 10:36:55 2002
> > *************** md_apply_fix3 (fixP, valP, seg)
> > *** 5165,5171 ****
> > if ((operand->flags & PPC_OPERAND_PARENS) != 0
> > && operand->bits == 16
> > && operand->shift == 0
> > ! && operand->insert == NULL
> > && fixP->fx_addsy != NULL
> > && symbol_get_tc (fixP->fx_addsy)->subseg != 0
> > && symbol_get_tc (fixP->fx_addsy)->class != XMC_TC
> > --- 5165,5171 ----
> > if ((operand->flags & PPC_OPERAND_PARENS) != 0
> > && operand->bits == 16
> > && operand->shift == 0
> > ! && (operand->insert == NULL || ppc_xcoff64)
> > && fixP->fx_addsy != NULL
> > && symbol_get_tc (fixP->fx_addsy)->subseg != 0
> > && symbol_get_tc (fixP->fx_addsy)->class != XMC_TC
>
> --
> Tom Rix
> GCC Engineer
> trix@redhat.com
>
>
>
>
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer