Re: src/binutils ChangeLog coffdump.c nlmconv.c nl ...

[Ian Lance Taylor <ian at airs dot com>]

drow@sources.redhat.com writes:

> 	* nlmconv.c: Add PARAMS ((const time_t *)) to localtime
> 	prototype.  Prototype main.
> 	* nlmheader.y: Add PARAMS ((int)) to strerror prototype.

Please don't make these changes.  The localtime change in particular
will cause the binutils to fail to compile on some platforms, those on
which localtime is declare in the system header files to take time_t *
rather than const time_t *.

Never use a full prototype when declaring functions provided the
system.  It can only cause conflicts and, except in the case of a
prototype which uses an ellipsis, can never help.  If you feel that
you must use a full prototype, you must add a configure test to
confirm that it will compile correctly.

Ian