This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] '0x' prefix on objdump addresses


On Thu, 2002-01-10 at 17:40, Andrew Cagney wrote:
> > Hi,
> > 
> > I've had a customer file a bug on this item, and on closer inspection it
> > appears that all objdump configurations fail to distinguish the printed
> > forms of different sorts of address operands which resolve near symbols;
> > eg. 15 (unsigned, hex) and 15 (signed, decimal). The hex ought to be
> > printed as 0x15, by customer's reckoning.
> 
> 
> Would you mind providing examples.

Sure:

$ objdump -d ne_locks.o

  [...]
  15f:   8b 1f                   mov    (%edi),%ebx
  161:   85 db                   test   %ebx,%ebx
- 163:   74 2b                   je     190 <submit_lock+0x40>
+ 163:   74 2b                   je     0x190 <submit_lock+0x40>
  165:   8d 74 26 00             lea    0x0(%esi,1),%esi
  169:   8d bc 27 00 00 00 00    lea    0x0(%edi,1),%edi
  [...]

It's a matter of consistency; all hex values in the disassembly _except_
this case are already prefixed by "0x".  

-graydon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]