This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bfd: patch for missing strtoull


Aldy Hernandez <aldyh@redhat.com> writes:

> hi guys!
> 
> MacOS X does not have strtoull so bfd doesn't build.  *sigh*  
> 
> here is a patch to add configury magic to check for strtoull, and if not
> available, use our own version of strtoull (stolen from newlib).
> 
> is this the right approach?

No.  The right approach is to add strtoull to newlib.  (As far as I
can see, newlib has strtoul, but not strtoull.)

Or perhaps the code which uses strtoull should use bfd_scan_vma
instead.  The value appears to being stored in a bfd_vma, not in a
long long.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]