Re: Old MIPS patch [drow@mvista.com: Re: Missing .cprestore warning]

[Daniel Jacobowitz <drow at mvista dot com>]

On Fri, Dec 14, 2001 at 05:10:06PM -0800, Eric Christopher wrote:
> 
> > 
> > Make check on x86-linux -> mipsel-linux, and verified that it warns on
> > all the bugs I'd been hunting for the past week :)  OK to commit it,
> > then?
> 
> Sure.

I was just about to commit this when I decided to cleverly rerun the
testsuite, since it had been a while.  I noticed a total of seven
failures due to this patch.  Here's one:

/opt/src/gdb/src/gas/testsuite/gas/mips/mips-gp32-fp32-pic.s: Assembler messages:
/opt/src/gdb/src/gas/testsuite/gas/mips/mips-gp32-fp32-pic.s:35:
Warning: No .frame pseudo-op used in PIC code
FAIL: MIPS -mgp32 -mfp32 (SVR4 PIC)

These testcases all depend on the fact that mips_frame_reg defaults to
SP.

I can fix the testcases to set .frame explicitly; I think it would be a
good idea, and that the warning is legitimate.  What do you think?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer