This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA] Make objcopy handle core files.
On Tue, Dec 18, 2001 at 02:08:54PM +1030, Alan Modra wrote:
> On Wed, Dec 12, 2001 at 03:23:32PM -0800, Michael Snyder wrote:
> >
> > * objcopy.c (copy_file): Accept corefiles (format bfd_core).
> > (copy_object): Don't set the start address or flags of a core file.
> > (copy_section): Don't relocate a core file. Don't copy contents
> > if the input section has the contents flag set, but the output
> > section does not (which happens with the fake 'note' pseudo-
> > sections that BFD creates for corefiles).
>
> OK.
>
> > ! /* Neither the start address nor the flags
> > ! need to be set for a core file. */
> > ! if (!bfd_check_format (ibfd, bfd_core))
>
> Doesn't bfd_get_format work here?
On second thoughts, this is a silly objection since bfd_check_format
doesn't do any work if the format is already known. So, the patch is
OK as is.
Alan